-
Couldn't load subscription status.
- Fork 3.6k
KHR_materials_volume_scatter import #17194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
KHR_materials_volume_scatter import #17194
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
1 similar comment
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17194/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/17194/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/17194/merge#BCU1XR#0 |
|
Devhost visualization test reporter: |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
|
This pull request has been marked as stale because it has been inactive for more than 14 days. Please update to "unstale". |
7c13529 to
8e6228b
Compare
|
Devhost visualization test reporter: |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
This isn't at all a full implementation of this WIP extension as the PBRMaterial doesn't have the ability to render SSS in the way expected by the extension. And I haven't started implementing transparency or subsurface in OpenPBRMaterial yet...
However, I think this provides a good starting point for future support in OpenPBRMaterial as it adds the appropriate properties in the material adapter and does the needed conversion to OpenPBR-compatible parameters from glTF.